[fixed] v2.10.10: Cannot delete attributes

Discuss, research, share, find, and solve bugs

[fixed] v2.10.10: Cannot delete attributes

Postby postmanpat » 5:14pm, Thu 07 May, 2009

Just installed version 2.10.10 and imported users to a list. The system has added an attribute "info" which I don't want and delete isn't working. Would someone tell me what else I would need to do if I delete it manually from users_attributes using a .sql query?
postmanpat
PL Nut
 
Posts: 37
Joined: 2:36pm, Mon 20 Mar, 2006

Re: New v-2.10.10 - added unwanted attribute

Postby postmanpat » 6:33pm, Thu 07 May, 2009

Edit: For anyone seeking solution to a problem, it's important to note this was my own error selecting the wrong import mode. With thanks to H2B2 for testing and reporting. The remaining issue is the inability to delete attributes in version 2.10.10. End of edit.

More on this - seems there's a serious bug: the system deleted all the list members when I deleted the info attribute from the database. Importing again using the test facility so the first 50 show on screen I get:
phplist - import emails
good evening admin
logout
Here you can add multiple emails to your lists. All emails need to have the same attributes, which you can identify below.

Test output::
There should only be ONE email per line.
If the output looks ok, go back to resubmit for real

Email

info -> Your Name

alias1@domain1.com

info -> Name1

alias2@pdomain2.co.uk

info -> Name2

alias3@domain3.com

info -> name3
There should not be any attribute called info. Where has it come from? I do not want it showing on the sign up page, not even as optional. I have put Your Name as an attribute. I only want Your Name as an attribute. People understand what their name is. What on earth is meant by info?

I had thought, using hand inserted rather than imported users into the test list, that the attribute bug had been fixed. Seems it's simply been swapped for another.
Last edited by postmanpat on 8:12am, Fri 08 May, 2009, edited 2 times in total.
postmanpat
PL Nut
 
Posts: 37
Joined: 2:36pm, Mon 20 Mar, 2006

Re: New v-2.10.10

Postby H2B2 » 8:26pm, Thu 07 May, 2009

postmanpat wrote:The system has added an attribute "info" which I don't want and delete isn't working.
I can confirm your findings with regard to deleting attributes on the configure attributes' page (lists/admin/?page=attributes).

Haven't tested the import feature yet.

Thread moved to the bug discussion section.
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

Re: v-2.10.10: Cannot delete attributes

Postby postmanpat » 8:39pm, Thu 07 May, 2009

Many thanks, H2B2. Very much appreciated.
postmanpat
PL Nut
 
Posts: 37
Joined: 2:36pm, Mon 20 Mar, 2006

Re: v-2.10.10: Cannot delete attributes

Postby H2B2 » 3:35am, Fri 08 May, 2009

H2B2 wrote:Haven't tested the import feature yet.
Well I did now. Since this is another issue, I created a separated thread. Please see Unwanted 'info' attribute created on import
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

Re: v-2.10.10: Cannot delete attributes

Postby H2B2 » 12:40am, Tue 12 May, 2009

Filed the following bug report:
v2.10.10: Delete attribute and Merge attribute feature does not seem to be working


BTW, if you have an attribute that you don't want included on your subscribe page and preferences page, you can simply edit the subscribe page (e.g. lists/admin/?page=spageedit&id=1), and uncheck the attribute's checkbox "Check this box to use this attribute in the page ".
ref: http://docs.phplist.com/EditSubscribePageInfo
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

Re: v2.10.10: Cannot delete attributes

Postby H2B2 » 3:21am, Fri 28 Aug, 2009

flo_reu posted the following fix in the bug tracker:

flo_reu wrote:solved the problem...
just change line number 148 in file admin/commonlib/pages/attributes.php from
if (isset($tagaction['delete'])) {

to:
if (isset($_POST["tagaction"]['delete'])) {


and then it works fine for me :)

btw... the same for the merge in line 171:

change:
} elseif (isset($tagaction['merge'])) {

to:
} elseif (isset($_POST["tagaction"]['merge'])) {

ref: http://mantis.phplist.com/view.php?id=15284
See also: Listing of reported bugs and fixes - 2.10.10

This fix has been included in the following patched file:
lists/admin/commonlib/pages/attributes.php

NOTE: Always make a backup op the original file before overwriting it with the patched file.
Attachments
attributes.zip
Patched file for v2.10.10: lists/admin/commonlib/pages/attributes.php
(4.65 KiB) Downloaded 1366 times
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

Re: v2.10.10: Cannot delete attributes

Postby myregistration » 6:34pm, Wed 02 Sep, 2009

I recently downloaded the install and this fix was not included. I had to search for the fix and replace the file manually. Why hasn't that attribute.php file been replaced in the current install package? Are there other files not up to date that could easily be included in the current release? Is realize it's open source, but is this application well maintained? Thanks!
myregistration
phpList newbie
 
Posts: 1
Joined: 6:28pm, Wed 02 Sep, 2009

Re: v2.10.10: Cannot delete attributes

Postby jake1729 » 9:13pm, Tue 29 Sep, 2009

I have tried this fix, but to no avail... any other ideas?
jake1729
phpList newbie
 
Posts: 2
Joined: 9:11pm, Tue 29 Sep, 2009

Re: v2.10.10: Cannot delete attributes

Postby hazymat » 2:52pm, Thu 01 Oct, 2009

I downloaded PHP list just now, and had to make this fix manually.
hazymat
phpList newbie
 
Posts: 3
Joined: 2:50pm, Thu 01 Oct, 2009

Re: v2.10.10: Cannot delete attributes

Postby openxs » 8:04pm, Wed 09 Dec, 2009

Thank-you so much, thought I was losing the plot for a while there!
openxs
phpList newbie
 
Posts: 1
Joined: 7:08pm, Wed 09 Dec, 2009

Re: v2.10.10: Cannot delete attributes

Postby RonFred » 6:24am, Sat 16 Jan, 2010

Thanks alot for the updated file: attributes.php

The updated version of the attributes.php worked great. Before the patch I was not able to delete a tagged attribute. Now deletion works fine.

Best regards,

Ron Fredericks
LectureMaker.com
RonFred
phpLister
 
Posts: 14
Joined: 7:23pm, Thu 27 Apr, 2006
Location: Sunnyvale, CA USA

Re: v2.10.10: Cannot delete attributes

Postby Dragonrider » 9:13am, Sat 16 Jan, 2010

hazymat wrote:I downloaded PHP list just now, and had to make this fix manually.

Yes, you will have to do. These are userfixes and as such the offical release needs to be checked that these fixes do not cause other problems.

Personally, I found that all such fixes that I've applied to my installations, have not affected the operation in any way other than to fix the problem.
My sites:- http://wharfedalefestival.co.uk, http://ilkleygardeners.org.uk, http://emergencyaid.net, http://dragonrider.co.uk
Latest phpList version is now 3.0.12 (3 February 2015) and requires a minimum of MySQL 5.0 and PHP 5.3.x
Dragonrider
Moderator
 
Posts: 3460
Joined: 6:58am, Sun 02 Jul, 2006
Location: Ilkley, West Yorkshire, United Kingdom

Re: v2.10.10: Cannot delete attributes

Postby Stardancer » 3:54pm, Tue 30 Mar, 2010

Added the fix. Yea! I can now delete checked attributes.
The program still is keeping a running total of all attributes i have ever had. listed attributes = 10 last attribute number is 27.

It still is ignoring the required field check mark and will not list the attributes in order.

This has not been the case historically just since the new version.
any help?
Thanks
Stardancer
phpList newbie
 
Posts: 2
Joined: 12:44am, Tue 30 Mar, 2010

Re: v2.10.10: Cannot delete attributes

Postby H2B2 » 2:26pm, Wed 14 Apr, 2010

Issue fixed in phpList v2.10.11
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006


Return to Bug Discussion

Who is online

Users browsing this forum: No registered users and 2 guests