[fxed]2.10.10: delete bounce not working on View a bounce pg

Discuss, research, share, find, and solve bugs

[fxed]2.10.10: delete bounce not working on View a bounce pg

Postby H2B2 » 6:37pm, Tue 12 May, 2009

nickyoung reported the following issue, and a fix, in the bug tracker:
nickyoung wrote:delete bounce operation doesn't work from 'view a bounce' page.
I just upgraded to 2.10.10.

Now when I go to the "View a bounce" page from the admin and then with "Delete this bounce and go to the next" checked, hit the "Do the above" button, the page refreshes and the bounce doesn't appear to be deleted.

It appears that the $deletebounce variable is not initialized from $_GET so it is always empty.

I fixed this issue by adding this at line 18 of admin/bounce.php:
Code: Select all
$deletebounce = isset($_GET["deletebounce"]) ? $_GET["deletebounce"] : '';

I don't know if this is the proper place to put the fix but it seems to work.

ref: http://mantis.phplist.com/view.php?id=15286
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

Re: v2.10.10: delete bounce not working on 'view a bounce' page

Postby Statick » 12:50pm, Sat 13 Jun, 2009

i can confirm both the bug and the above fix
Statick
phpLister
 
Posts: 12
Joined: 11:44am, Thu 11 Jun, 2009

Re: v2.10.10: delete bounce not working on 'view a bounce' page

Postby jeremykay » 3:00pm, Wed 26 Aug, 2009

It appears you need to do the same for the other bounce management options, including "deleteuser", "unconfirm", and "maketext".
jeremykay
phpList newbie
 
Posts: 4
Joined: 5:39pm, Fri 21 Aug, 2009

Re: v2.10.10: delete bounce not working on 'view a bounce' page

Postby H2B2 » 1:18pm, Sun 30 Aug, 2009

Inserted the code suggested by nickyoung and CS2 in the mantis report, at line 18 of lists/admin/bounce.php:
Code: Select all
$deletebounce = isset($_GET["deletebounce"]) ? $_GET["deletebounce"] : '';
$amount = isset($_GET["amount"]) ? $_GET["amount"] : '';
$unconfirm = isset($_GET["unconfirm"]) ? $_GET["unconfirm"] : '';
$maketext = isset($_GET["maketext"]) ? $_GET["maketext"] : '';
$deleteuser = isset($_GET["deleteuser"]) ? $_GET["deleteuser"] : '';

Ran a quick test. All options seem to be working now. Thanks!

The above patch has been included in the attached lists/admin/bounce.php file:
Attachments
bounce.zip
Patched lists/admin/bounce.php
(2.04 KiB) Downloaded 676 times
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

Re: v2.10.10: delete bounce not working on 'view a bounce' page

Postby Maestro » 6:27am, Wed 02 Sep, 2009

I have downloaded and installed the patched file on the server but the behaviour seems unchanged. The same page seems to just refresh with the same user email and none of the options like delete user have worked.
Maestro
phpLister
 
Posts: 5
Joined: 6:25am, Wed 02 Sep, 2009

Re: v2.10.10: delete bounce not working on 'view a bounce' page

Postby H2B2 » 8:02am, Wed 02 Sep, 2009

Assuming you have checked that the original file was actually overwritten by the patched file, did you log out, flushed browser cache and log in again, before testing the 'view a bounce' page options?
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

Re: v2.10.10: delete bounce not working on 'view a bounce' page

Postby Maestro » 9:32pm, Wed 02 Sep, 2009

I have checked that patched file is on server. It has these bug fix lines:
$deletebounce = isset($_GET["deletebounce"]) ? $_GET["deletebounce"] : ''; #BUGFIX #15286 - nickyoung
$amount = isset($_GET["amount"]) ? $_GET["amount"] : ''; #BUGFIX #15286 - CS2
$unconfirm = isset($_GET["unconfirm"]) ? $_GET["unconfirm"] : ''; #BUGFIX #15286 - CS2
$maketext = isset($_GET["maketext"]) ? $_GET["maketext"] : ''; #BUGFIX #15286 - CS2
$deleteuser = isset($_GET["deleteuser"]) ? $_GET["deleteuser"] : ''; #BUGFIX #15286 - CS2

Also not only cleared cache but used a different browser and a different PC altogether.
But the same page just refreshes and none of the actions are carried out.
Maestro
phpLister
 
Posts: 5
Joined: 6:25am, Wed 02 Sep, 2009

Re: v2.10.10: delete bounce not working on 'view a bounce' page

Postby psoukal » 6:09pm, Mon 25 Jan, 2010

I've applied to patch to bounce.php as suggested by H2B2 and nickyoung and the view a bounce page function are now working! Thanks.
psoukal
phpList newbie
 
Posts: 1
Joined: 6:04pm, Mon 25 Jan, 2010

Re: v2.10.10: delete bounce not working on 'view a bounce' page

Postby davkrev » 7:43pm, Mon 08 Feb, 2010

I have tried uploading the new version of bounce.php posted above and it still does not work for me. This is what I see when I go to the view bounce page:

Image

Anyone know how I can fix this? I logged out and logged back in, cleared cache, everything.
davkrev
phpLister
 
Posts: 5
Joined: 1:47am, Thu 24 Nov, 2005

Re: v2.10.10: delete bounce not working on 'view a bounce' page

Postby H2B2 » 2:28pm, Wed 14 Apr, 2010

"Delete bounce not working on 'view a bounce' page" has been fixed in phpList v2.10.11
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006


Return to Bug Discussion

Who is online

Users browsing this forum: Bing [Bot] and 2 guests

cron