[fix] failed emails aren't removed from the queue

[thisisit3]

If you see something like this:

1599 emails failed (will retry later)

Then chances are your process queue is broken, it will take weeks to remove all those emails from the queue. I don't know why, but there is a simple piece of code that can "unsubscribe" failed users automaticaly, but its disabled by default.

The following patch will enable automatic unsubscription of failed emails and your process queue will run much faster and will complete without any issues related to failed emails.

Code: Select all

--- processqueue.php.orig       2007-05-07 00:33:57.000000000 +0300
+++ processqueue.php    2007-05-07 00:34:45.000000000 +0300
@@ -668,11 +668,11 @@
              }
              # make sure it's not because it's an invalid email
              # unconfirm this user, so they're not included next time
-             if (!$throttled && !validateEmail($useremail)) {
+             //if (!$throttled && !validateEmail($useremail)) {
                logEvent("invalid email $useremail user marked unconfirmed");
                Sql_Query(sprintf('update %s set confirmed = 0 where email = "%s"',
                  $GLOBALS['tables']['user'],$useremail));
-             }
+             //}
            }
            if ($script_stage < 5) {
              $script_stage = 5; # we have actually sent one user


[itsrich]

I need a little help clarifying what thisisit3 is telling me to change.

It appears I am being directed to add // in two places.

I can edit the code, just looking for clarification of what changes to make.

Thanks in advance!

[thisisit3]

thats correct, if you comment out those two lines then failed emails will be automatically marked as unconfirmed, thus won't be retried for sending and keeping the queue "full".

[raybman]

Thanks, I'll give it a go.

[mikeaja]

This fix worked great so far for me. Had the same problem as the OP, and could find no way of getting to the end of the send (to view the stats).

Thanks.

[FlagKing]

That's an amazing tip!

Thanks to you Thisisit3!