2.10.10 Second subscribe window on form submission

Discuss, research, share, find, and solve bugs

2.10.10 Second subscribe window on form submission

Postby FatalMusic » 10:26am, Thu 15 Jan, 2009

Hello,

I've upgraded to the latest version.. and now i run into the following problem:

when i subscribe from my webpage OR from the subscribe page itself, it opens the subscribe page again, WITHIN the subscribe page.

can someone please check it out and view the source code to see what i need to change? it was working fine before...

u can see what i mean by signing up via :

http://www.fatalmusicgroup.com/mailingl ... cribe&id=1



also the validation is no longer working from my webpage subscribe form.. it used to before the upgrade. All i did was copy & paste the form + validation script from my subscribe page into my webpage..

thanks for your time in advance!

Iris
FatalMusic
PL Nut
 
Posts: 21
Joined: 1:20pm, Sun 21 May, 2006

Postby FatalMusic » 11:53am, Thu 15 Jan, 2009

well i just found out the weirdest thing:

the problem ONLY happens.. when i sign up with 1 particular gmail email address...

any other email address (that i tried) works fine.. it seems that just that 1 email address gives the error??

now i am really confused.. :shock:

whatever..

i uploaded all the files again clean and deleted the subscribe page and created it new btw.
FatalMusic
PL Nut
 
Posts: 21
Joined: 1:20pm, Sun 21 May, 2006

I'm having the same exact problem - nested subscribe forms

Postby Cajun82 » 4:57pm, Thu 19 Feb, 2009

I have the same problem....Anyone found a solution?

I'm using version 2.10.8 and my PHP version is 5.28 on my hostgator server.

It only happens with the subscribe page.
It was working fine until yesterday.

Thanks in advance for the help!

Sincerely,
Ken
Cajun82
phpList newbie
 
Posts: 3
Joined: 4:43pm, Thu 19 Feb, 2009

Postby woolef » 10:13am, Mon 23 Feb, 2009

I get the "second window on form submission" problem (using 2.10.9), but I found out the following;

  • a new email address (ie. one that phplist doesn't know about) works fine.
  • an existing email address (ie. one that is subscribed to a list in my phplist) works fine and you just get a 'thanks for subscribing' message.
  • an email address in your db that has been marked as blacklisted will get the second window error.
  • a deleted email address in your db that was marked as blacklisted before deletion will just get added back to your db with the same second window error


Someone who knows about deleting a record out of the db might be able to help but I'm not going to waste my time on a record that is blacklisted anyway.

Can anyone else confirm the above on their installation?
woolef
PL Nut
 
Posts: 21
Joined: 10:40pm, Tue 17 Feb, 2009

Postby Green_Hornet » 10:52am, Tue 24 Feb, 2009

Thank god, I'm not alone. My topic number is: 23878

I didnt find a solution. :(
Green_Hornet
phpList newbie
 
Posts: 4
Joined: 5:32pm, Thu 19 Feb, 2009

Postby H2B2 » 5:13pm, Sat 28 Feb, 2009

woolef wrote:an email address in your db that has been marked as blacklisted will get the second window error.

I just ran a test on v2.10.9 and can confirm your findings.

Filed a bug report: http://mantis.phplist.com/view.php?id=15214
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

Postby michiel » 2:35pm, Thu 05 Mar, 2009

michiel
Admin
 
Posts: 1022
Joined: 10:18pm, Fri 11 Apr, 2003
Location: Buenos Aires, Argentina

Postby H2B2 » 3:36pm, Thu 05 Mar, 2009

michiel wrote:I presume you mean http://mantis.phplist.com/view.php?id=15240
Yes, you're right, I pasted the wrong link in my previous post. Thanks for correcting.
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

v2.10.10 - Second subscribe window on form submission

Postby H2B2 » 10:20pm, Thu 14 May, 2009

Issue seems to still occur in v2.10.10

Related bug report: http://mantis.phplist.com/view.php?id=15290
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

Re: Second subscribe window on form submission

Postby yogoo » 9:51pm, Sat 13 Jun, 2009

The issue of the double window still occurs in 2.10.10....

1. To fix it:

file: lists/admin/subscribelib2.php
at line 364, look for this code:

Code: Select all
   if ($blacklisted) {
      $thankyoupage .= '<p>'.$GLOBALS["strYouAreBlacklisted"].'</p>';
      return 1;
   }


change it to that:

Code: Select all
   if ($blacklisted) {
      $thankyoupage .= '<p>'.$GLOBALS["strYouAreBlacklisted"].'</p>';
      #return 1;
   }


The fix consists in commenting out the line 366
Code: Select all
#return 1;

Now the second window bug should be gone.

2. Go further:

If a user is blacklisted and re-subscribes, the "thank you page" displays an alert message to inform the user that he is blacklisted and that he should contact the administrator. In fact, it is not necessary because the user receives a confirmation email with a confirmation link. By clicking on the confirmation link, the user is confirmed and removed from the blacklist.

We can safely remove the warning message.

To do that:

file: lists/admin/subscribelib2.php (the same file as above)
at line 362, look for this code:

Code: Select all
   $blacklisted = isBlackListed($email);

   if ($blacklisted) {
      $thankyoupage .= '<p>'.$GLOBALS["strYouAreBlacklisted"].'</p>';
      return 1;
   }


change it to that:

Code: Select all
   #$blacklisted = isBlackListed($email);

   #if ($blacklisted) {
   #   $thankyoupage .= '<p>'.$GLOBALS["strYouAreBlacklisted"].'</p>';
   #  return 1;
   #}


We simply comment out the whole thing.

3. Downloads:

For the lazy, I uploaded the file with the appropriate modifications ;)

subscribelib2.zip
original file with second window bug fixed
(9.2 KiB) Downloaded 640 times


[UPDATE - 4 Oct. 2009]

Finally uploaded a patch (if you don't know what's a patch, download the file above):

second_window_bug_patch.zip
second window bug patch
(516 Bytes) Downloaded 358 times
Last edited by yogoo on 7:23am, Sun 04 Oct, 2009, edited 4 times in total.
yogoo
phpList newbie
 
Posts: 3
Joined: 9:16pm, Sat 13 Jun, 2009

Re: Second subscribe window on form submission

Postby ThorstenAlbrecht » 4:13pm, Thu 06 Aug, 2009

Thank you, works without any problem. Now any blacklisted user can resubscribe by himself without any problem.

Thorsten
ThorstenAlbrecht
PL Nut
 
Posts: 44
Joined: 4:08pm, Thu 06 Aug, 2009

Re: Second subscribe window on form submission

Postby desertlavender » 4:11pm, Tue 29 Sep, 2009

Yogoo, you rock! Totally fixed my problem. Many thanks!
desertlavender
phpList newbie
 
Posts: 2
Joined: 4:08pm, Tue 29 Sep, 2009

Re: Second subscribe window on form submission

Postby rdc » 12:23am, Sun 04 Oct, 2009

Thank you for this fix, I have been going nuts about this. New to phplist--thanks much for this forum.
rdc
phpList newbie
 
Posts: 1
Joined: 12:18am, Sun 04 Oct, 2009

Re: Second subscribe window on form submission

Postby odoturgeon » 11:47am, Sun 04 Oct, 2009

This is awesome.. Thanks for helping me fix this thing.
very nice thread.. :D
odoturgeon
phpList newbie
 
Posts: 1
Joined: 11:31am, Sun 04 Oct, 2009

Re: Second subscribe window on form submission

Postby shim » 9:59pm, Thu 10 Dec, 2009

Strictly speaking, this fix is incorrect. The whole point of blacklisting is that the user has chosen to never receive any more emails and needs an admin to remove them from the blacklist.

It seems that really the code should be changed from
Code: Select all
   if ($blacklisted) {
      $thankyoupage .= '<p>'.$GLOBALS["strYouAreBlacklisted"].'</p>';
      return 1;
   }

   if ($sendrequest && $listsok) { #is_array($_POST["list"])) {


to
Code: Select all
   if ($blacklisted) {
      print '<p>'.$GLOBALS["strYouAreBlacklisted"].'</p>';
   }
   elseif ($sendrequest && $listsok) { #is_array($_POST["list"])) {
shim
phpList newbie
 
Posts: 1
Joined: 9:50pm, Thu 10 Dec, 2009

Next

Return to Bug Discussion

Who is online

Users browsing this forum: No registered users and 1 guest

cron