Unsubscribe reason still asked even when disabled

Discuss, research, share, find, and solve bugs

Unsubscribe reason still asked even when disabled

Postby Guest » 10:56pm, Mon 17 Nov, 2008

Hi All

Just installed PHPList and it went almost perfectly.

I would like people to be unsubscribed automatically when they click the Unsubscribe link, but even though UNSUBSCRIBE_JUMPOFF is set to 1 in config.php,

Code: Select all
# if a user should immediately be unsubscribed, when using their personal URL, instead of
# the default way, which will ask them for a reason, set this to 1
define("UNSUBSCRIBE_JUMPOFF",1);


it still asks for a reason each time.

It's obviously registering the UID in the unsubscribe URL, because the correct user email address is already filled into the form field after "Please enter a valid email address".

The settings seem a bit confused, beause even though I'm asked for a reason, the admin email telling me that someone has unsubscribed says:

Code: Select all
(user's email address) has unsubscribed
Reason given:
"Jump off" set, reason not requested


So it seems like it's registered the UNSUBSCRIBE_JUMPOFF setting, but it's not doing what it says it's going to do.

Has anyone else had this problem? Is there anything that might I might be missing?

I'm using PHPList v 2.10.7, and everything else is working perfectly...

Cheers

Adrian
Guest
 

Postby Guest » 6:23pm, Tue 02 Dec, 2008

*bump*

Anyone? I'd really like to figure this out, as I want to make the system live before Christmas if possible. I'm up for getting my hands dirty with a bit of code if necessary.

I'd even appreciate replies from people who have this working with no problems, just so I know I'm not trying something that isn't working yet...

Thanks

Adrian
Guest
 

Postby H2B2 » 8:29pm, Tue 02 Dec, 2008

I just ran a test on 2.10.7 with UNSUBSCRIBE_JUMPOFF" set to 1, both by unsubscribing from
1. a personalized unsubscribe link (unsubscribe url + uid) contained in a message the user received (e.g. lists/?p=unsubscribe&uid=c2672b3f595..etc.)
2. a non-personalized link (e.g. lists/?p=unsubscribe)

In both cases the 'tell us why' textarea is displayed. So, this confirms your findings and seems to indicate there is a bug in this feature.

Could you file a bug report at http://mantis.phplist.com , and include a reference to this thread?
Thx


Moving this thread to the 'bug discussion' section.

EDIT: corrected url to bugtracker (without www.)
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

Postby Guest » 9:11pm, Tue 02 Dec, 2008

Thanks, er, "Bill" :)

I've added that to mantis.

Nice to know I'm not going mad...

Cheers

Adrian
Guest
 

Postby CS » 9:14pm, Tue 02 Dec, 2008

Interesting...this feature worked perfectly in 2.10.5.
CS
 

Postby H2B2 » 9:43pm, Tue 02 Dec, 2008

adriantoll wrote:I'm up for getting my hands dirty with a bit of code if necessary.
You could take a look at these mods and see if they still work for 2.10.7:
http://forums.phplist.com/viewtopic.php?p=40015
http://forums.phplist.com/viewtopic.php?t=10345

And thanks for filing this bug report: http://mantis.phplist.com/view.php?id=15195
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

Postby rdaneel » 3:26pm, Wed 25 Feb, 2009

line 717 in index.php

Code: Select all
}else{


should read
Code: Select all
} elseif(!$_POST["unsubscribereason"]) { 


Ralph and Nico :)
rdaneel
phpList newbie
 
Posts: 3
Joined: 10:12am, Wed 25 Feb, 2009

Postby H2B2 » 6:36pm, Fri 20 Mar, 2009

Thanks! I've included your suggested fix in this mantis report: http://mantis.phplist.com/view.php?id=15212
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

Postby CS2 » 7:19pm, Fri 20 Mar, 2009

rdaneel's suggestion should probably work, but I think that
Code: Select all
} elseif (!UNSUBSCRIBE_JUMPOFF) {
might make more sense.
CS2
PL Master
 
Posts: 216
Joined: 2:20am, Wed 04 Feb, 2009

Postby H2B2 » 8:43pm, Fri 20 Mar, 2009

It might indeed. Could you add your suggested fix to the http://mantis.phplist.com/view.php?id=15212 mantis report? Thanks!
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

SOLVED, THANK YOU

Postby Andy000 » 10:26pm, Fri 27 Mar, 2009

Thanks! works for me too.
Andy000
PL Nut
 
Posts: 18
Joined: 12:00am, Fri 27 Mar, 2009
Location: New Zealand South Island

v2.10.10: Unsubscribe reason still asked even when disabled

Postby H2B2 » 10:24pm, Thu 14 May, 2009

This issue seems to have re-emerged in v2.10.10.

See related bug report: http://mantis.phplist.com/view.php?id=15289
H2B2
Moderator
 
Posts: 7188
Joined: 1:51am, Wed 15 Mar, 2006

SOLVED: Unsubscribe reason still asked even when disabled

Postby Andy000 » 9:09pm, Tue 02 Jun, 2009

Hi there,

In case this fix has not yet been documented:
When upgrading to 2.10.10, this problem reappeared. I re-applied the old fix from 2.10.9 (thanks to whomever came up with it), and it works!
The fix has moved down a few lines.

If you have already set UNSUBSCRIBE_JUMPOFF to 1 in config.php, open index.php and find the piece of code with:
Code: Select all
if ($blacklist) {
$res .= $GLOBALS["strExplainBlacklist"];
} else {
list($r,$c) = explode(",",getConfig("textarea_dimensions"));
It should be on line 728.

Replace line 730 ( } else { ) with
Code: Select all
} elseif (!UNSUBSCRIBE_JUMPOFF) {


In case anyone is afraid of upgrading, I wrote down a few lines about my experience upgrading phplist from 2.10.9 to 2.10.10.

Smiles,

Andy
Andy000
PL Nut
 
Posts: 18
Joined: 12:00am, Fri 27 Mar, 2009
Location: New Zealand South Island


Return to Bug Discussion

Who is online

Users browsing this forum: No registered users and 0 guests